Unity

Merge lp://qastaging/~3v1n0/unity/quick-alt+tab-fixes into lp://qastaging/unity

quick-alt+tab-fixes
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2011-12-14

Status:

Merged

Merged at revision:

2282

Proposed branch:

lp://qastaging/~3v1n0/unity/quick-alt+tab-fixes

Merge into:

lp://qastaging/unity

Diff against target:

211 lines (+86/-38)

5 files modified

manual-tests/QuickAltTab.txt (+17/-0)
plugins/unityshell/src/BamfLauncherIcon.cpp (+16/-4)
plugins/unityshell/src/PluginAdapter.cpp (+44/-31)
plugins/unityshell/src/SwitcherController.cpp (+8/-3)
plugins/unityshell/src/WindowManager.h (+1/-0)

To merge this branch:

bzr merge lp://qastaging/~3v1n0/unity/quick-alt+tab-fixes

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Tim Penhey (community)		2011-12-14	Needs Information on 2011-12-14
Review via email: mp+85583@code.qastaging.launchpad.net

Description of the change

Make the quick Alt+Tab more consistent.

The quick Alt+Tab should be handled in a different way according to bug #861250, so I've made it possible by making the SwitcherController to use the ActionArg button member to define the type of the switch that has been performed (I've made this not to add an extra member to the class, but this can be changed if you want the code to be more clean).
Then the activated BamfLauncherIcon redirects this information to the PluginAdapter's FocusWindowGroup that now when called with the FocusVisibility::OnlyVisibleOnTop visibility option, just brings to focus the first window that is on top of the stack (for the given application).

A manual test is included.

Revision history for this message

Tim Penhey (thumper) wrote on 2011-12-14:

How does this interaction work with the alt-tab switcher defaulting to only showing applications running on the same workspace? Are there any considerations we have to make there?

review: Needs Information

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-12-14:

Mh, in that case this modification doesn't affect the switcher behavior.

I've to look better to this case, to see how we can handle it correctly.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-12-14:

> How does this interaction work with the alt-tab switcher defaulting to only
> showing applications running on the same workspace? Are there any
> considerations we have to make there?

I've gave a look to this, but in this case it's the switcher itself that defines the possible windows to switch to.
So, In that case, my code is used with only a subset of windows, and so it should continue to work as expected.