Merge lp://qastaging/~3v1n0/unity/quicklist-app-name-spread-fix into lp://qastaging/unity
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2342 |
| Proposed branch: | lp://qastaging/~3v1n0/unity/quicklist-app-name-spread-fix |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
391 lines (+163/-16) 13 files modified
plugins/unityshell/src/BamfLauncherIcon.cpp (+10/-1) plugins/unityshell/src/BamfLauncherIcon.h (+1/-0) plugins/unityshell/src/PluginAdapter.cpp (+14/-0) plugins/unityshell/src/PluginAdapter.h (+1/-0) plugins/unityshell/src/WindowManager.cpp (+9/-0) plugins/unityshell/src/WindowManager.h (+7/-9) plugins/unityshell/src/unityshell.cpp (+1/-1) plugins/unityshell/src/unityshell.h (+2/-2) tests/autopilot/autopilot/emulators/unity/quicklist.py (+4/-0) tests/autopilot/autopilot/emulators/unity/window_manager.py (+22/-0) tests/autopilot/autopilot/keybindings.py (+3/-0) tests/autopilot/autopilot/tests/__init__.py (+7/-0) tests/autopilot/autopilot/tests/test_quicklist.py (+82/-3) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/quicklist-app-name-spread-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomi Richards (community) | Approve | ||
|
Review via email:
|
|||
Commit message
BamfLauncherIcon: activate the icon using the quicklist item using an Idle.
This fixes the bug #986461 that caused the spread not to initiate clicking on the quicklist application name.
Description of the change
When the quicklist application name item is clicked the spread should eventually initiate (if the application is active and visible), but this doesn't seem to work anymore.
The problem seems to be due to the fact that the quicklist view grab is still active when the "item-activated" event happens, and so compiz doesn't seem to be able to initiate the scale plugin.
Adding an idle on the activate event fixes the issue.
Fix tested using Autopilot, added introspection support to the WindowManager and PluginAdapter classes.
To post a comment you must log in.
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Approved.
Probably want to get someone who knows the unity-side of things to look through this as well though.