lp://qastaging/~3v1n0/unity/quicklist-item-glow-selection

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://qastaging/unity

Unity Team: Pending requested 2012-01-03

Diff: 571 lines (+106/-146)

7 files modified

plugins/unityshell/src/QuicklistMenuItem.cpp (+54/-10)
plugins/unityshell/src/QuicklistMenuItem.h (+4/-5)
plugins/unityshell/src/QuicklistMenuItemCheckmark.cpp (+10/-37)
plugins/unityshell/src/QuicklistMenuItemLabel.cpp (+5/-25)
plugins/unityshell/src/QuicklistMenuItemRadio.cpp (+9/-42)
plugins/unityshell/src/QuicklistMenuItemSeparator.cpp (+8/-8)
plugins/unityshell/src/QuicklistView.cpp (+16/-19)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #911443: Quicklist highlight should use a glow effect

Medium

Invalid

Link a bug report

Related blueprints

1803. By Marco Trevisan (Treviño) on 2012-01-03

QuicklistMenuItem*: add a shared function to Draw the Prelight that applies a blurred glow

All the kinds of QuicklistMenuitems now uses the shared DrawText and DrawPrelight functions
to draw the content, these functions are also aware of the padding that the quicklist item
should use.

The DrawPrelight function uses some heuristic to get the best result, instead of just drawing
a blurred rectangle under the opaque one.

Plus, now the disabled quicklist are using a semi-transparent white color, computed comaparing
the results with the design mokups.

1802. By Marco Trevisan (Treviño) on 2012-01-03

QuicklistView: don't define the padding of each MenuItemView, leave the children to set it

The quicklist view shouldn't define the padding of each child, but each one should take all the
space and then draw there what it wants. This allows to use all the quicklist space on the menu items
and to draw a glow without reducing the item area.

1801. By Marco Trevisan (Treviño) on 2011-12-31

QuicklistMenuItemRadio: fix the rendering of the active/unactive and disabled states

Fixing bug #910286 caused the menuitem to be drawn incorrectly

1800. By Marco Trevisan (Treviño) on 2011-12-31

QuicklistMenuItemCheckmark: fix the rendering of the active/unactive and disabled states

Fixing bug #910286 caused the menuitem to be drawn incorrectly

1799. By Chase Douglas on 2011-12-24

Fix a unity crash if utouch fails to initialize.. Fixes: https://bugs.launchpad.net/bugs/860707. Appoved by Sam Spilsbury.

1798. By Sam Spilsbury on 2011-12-24

Splits code into files. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Voß.

1797. By Sam Spilsbury on 2011-12-23

s/Unity/unity. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Voß.

1796. By Sam Spilsbury on 2011-12-23

Refactors the code to make it testable. Fixes: https://bugs.launchpad.net/bugs/907174. Appoved by Thomas Voß.

1795. By Andrea Azzarone on 2011-12-21

. Fixes: https://bugs.launchpad.net/bugs/839467. Appoved by Andrea Cimitan.

1794. By Alex Launi on 2011-12-20

When we call next icon we roll over to the show desktop icon at index 0, failing the test. This isn't really what we want anyway. Launching a third application makes the array big enough that this doesn't occur.. Fixes: . Appoved by Allan LeSage.