Merge lp://qastaging/~3v1n0/unity/scale-crash-fix-1052683 into lp://qastaging/unity
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Brandon Schaefer |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2714 |
| Proposed branch: | lp://qastaging/~3v1n0/unity/scale-crash-fix-1052683 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
35 lines (+4/-3) 2 files modified
plugins/unityshell/src/unityshell.cpp (+2/-2) plugins/unityshell/src/unityshell.h (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/scale-crash-fix-1052683 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brandon Schaefer (community) | Approve | ||
|
Review via email:
|
|||
Commit message
UnityWindow: implements sigc::trackable
Description of the change
UnityWindow connects to signals using sigc::mem_fun, we should inherit from sigc::trackable to be sure that the signals get disconnected properly.
To post a comment you must log in.
Revision history for this message
| Omer Akram (om26er) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me . +1