Unity

Merge lp://qastaging/~3v1n0/unity/secondary-activate-support into lp://qastaging/unity

secondary-activate-support
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2011-07-19

Status:

Merged

Approved by:

Mirco Müller on 2011-07-21

Approved revision:

no longer in the source branch.

Merged at revision:

1316

Proposed branch:

lp://qastaging/~3v1n0/unity/secondary-activate-support

Merge into:

lp://qastaging/unity

Diff against target:

290 lines (+91/-6)

12 files modified

UnityCore/DBusIndicators.cpp (+16/-0)
UnityCore/DBusIndicators.h (+2/-0)
UnityCore/Indicator.cpp (+7/-0)
UnityCore/Indicator.h (+2/-0)
UnityCore/IndicatorEntry.cpp (+5/-0)
UnityCore/IndicatorEntry.h (+2/-0)
UnityCore/Indicators.cpp (+1/-0)
UnityCore/Indicators.h (+2/-0)
plugins/unityshell/src/PanelIndicatorObjectEntryView.cpp (+19/-4)
services/panel-main.c (+16/-0)
services/panel-service.c (+15/-2)
services/panel-service.h (+4/-0)

To merge this branch:

bzr merge lp://qastaging/~3v1n0/unity/secondary-activate-support

Related bugs:

Bug #609860: mute/unmute sound when user clicks on sound applet using scroll button or middle mouse button	Undecided	Fix Released
Bug #812933: Secondary activate (i.e. middle click) support for indicators advanced usage	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Mirco Müller (community)		2011-07-19	Approve on 2011-07-21
Review via email: mp+68394@code.qastaging.launchpad.net

Description of the change

Add support to "secondary-activate" event on middle-click, needed both by bug #609860 and bug #812933. See the second for more informations.

This needs the merge of lp:~3v1n0/libindicator/secondary-activate-support

Revision history for this message

Mirco Müller (macslow) wrote on 2011-07-21:

All good seen from here. Approved.

review: Approve

Revision history for this message

Mirco Müller (macslow) wrote on 2011-07-21:

I've not merged this yet to trunk as it needs some stuff to move into libindicator first. Locally I tried this and it works ok.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-07-21:

Yes, it just needs support from the low-level, I just hope that the fact of exporting the X/Y mouse position (that I did for following the StatusNotifierItem specs) is accepted by ted :P.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-07-21:

I've changed the branch to sync with the change of libindicator that doesn't support the x,y mouse position when sending a secondary-activate signal.