Unity

Merge lp://qastaging/~3v1n0/unity/spread-title-improved into lp://qastaging/unity

spread-title-improved
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2012-09-05

Status:

Merged

Approved by:

Marco Trevisan (Treviño) on 2012-09-07

Approved revision:

no longer in the source branch.

Merged at revision:

2668

Proposed branch:

lp://qastaging/~3v1n0/unity/spread-title-improved

Merge into:

lp://qastaging/unity

Prerequisite:

lp://qastaging/~renatofilho/unity/unity-lp876017-fixes

Diff against target:

1202 lines (+387/-393)

2 files modified

plugins/unityshell/src/unityshell.cpp (+366/-367)
plugins/unityshell/src/unityshell.h (+21/-26)

To merge this branch:

bzr merge lp://qastaging/~3v1n0/unity/spread-title-improved

Related bugs:

Bug #1033935: Window management - Display full size window decorations on currently selected window in spread	High	Fix Released
Bug #1045127: Close from spread is unreliable	Low	Fix Released
Bug #1046124: Spread window close button does not react to mouse events	Low	Fix Released
Bug #1046126: Decoration in spread windows should hide the standard decoration	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
jenkins (community)	continuous-integration		Needs Fixing on 2012-09-06
Renato Araujo Oliveira Filho (community)		2012-09-05	Approve on 2012-09-05
Review via email: mp+122782@code.qastaging.launchpad.net

Commit message

UnityWindow: use smart pointers, use static close_icon (with dynamic state) and PanelStyle context

Description of the change

Improved the UnityWindow code used to handle the spread icons, I've changed the way we draw our fake decoration (I made it to be above the standard one) and added support for close button states (normal, prelighted and pressed).
Also, some code optimizations to avoid that shared resources are re-computed more than needed.

Shot: http://i.imgur.com/NAETd.jpg