Merge lp://qastaging/~3v1n0/unity/static-quicklist-startup-notification into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: no longer in the source branch.
Merged at revision: 3293
Proposed branch: lp://qastaging/~3v1n0/unity/static-quicklist-startup-notification
Merge into: lp://qastaging/unity
Diff against target: 185 lines (+58/-21)
6 files modified
launcher/ApplicationLauncherIcon.cpp (+6/-2)
launcher/QuicklistMenuItem.cpp (+5/-3)
launcher/QuicklistMenuItem.h (+1/-0)
tests/autopilot/unity/tests/__init__.py (+8/-0)
tests/autopilot/unity/tests/launcher/test_icon_behavior.py (+0/-6)
tests/autopilot/unity/tests/test_quicklist.py (+38/-10)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/static-quicklist-startup-notification
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Łukasz Zemczak autopilot Approve
Brandon Schaefer (community) Approve
Andrea Azzarone (community) unity code Approve
Thomi Richards autopilot Pending
Review via email: mp+157934@code.qastaging.launchpad.net

Commit message

ApplicationLauncherIcon: use GAppLaunchContext to open indicator shortcuts

Using the new indicator_desktop_shortcuts_nick_exec_with_context passing to it
the context containing the timestamp of the quicklist activation event.

Description of the change

Using indicator_desktop_shortcuts_nick_exec_with_context to open unity static quicklist with proper timestamp, so that startup-notify will work as expected (and also the compiz Focus Stealing prevention).

Added an autopilot test, also fixed the test_quicklist_actions so that it works with any locale now.

PS: make sure to use lp:~3v1n0/libindicator/shortcut-nicks-startup-notify-13.04 or the test won't pass.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

lgtm

review: Approve (unity code)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Test pass for me, LGTM

review: Approve
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Test wise the code looks ok. As mentioned already, good to know DesktopEntry has so many convenient methods!

review: Approve (autopilot)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.