Unity

Merge lp://qastaging/~3v1n0/unity/super-tab-switcher into lp://qastaging/unity

super-tab-switcher
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2012-01-07

Status:

Merged

Approved by:

Marco Trevisan (Treviño) on 2012-01-15

Approved revision:

no longer in the source branch.

Merged at revision:

1834

Proposed branch:

lp://qastaging/~3v1n0/unity/super-tab-switcher

Merge into:

lp://qastaging/unity

Diff against target:

443 lines (+225/-54)

8 files modified

manual-tests/SuperTab.txt (+22/-0)
plugins/unityshell/src/Launcher.cpp (+133/-46)
plugins/unityshell/src/Launcher.h (+10/-1)
plugins/unityshell/src/UBusMessages.h (+2/-0)
plugins/unityshell/src/unity-root-accessible.cpp (+8/-3)
plugins/unityshell/src/unityshell.cpp (+36/-4)
plugins/unityshell/src/unityshell.h (+4/-0)
plugins/unityshell/unityshell.xml.in (+10/-0)

To merge this branch:

bzr merge lp://qastaging/~3v1n0/unity/super-tab-switcher

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Mirco Müller (community)		2012-01-07	Needs Fixing on 2012-01-12
Review via email: mp+87851@code.qastaging.launchpad.net

Description of the change

Fixed bug #891620 to support the Super+Tab switcher.

Added a new launcher key switcher that matches design bug #891620, the key bindings are set to default to Super+Tab and Super+Shift+Tab by default, but they can be changed from compiz settings.

I've added some new functions to Launcher to manage the KeySwitcher and others to share the code between the switcher and the key navigation.

Revision history for this message

Mirco Müller (macslow) wrote on 2012-01-12:

The patch works as described in the manual test. Code looks ok too. But again the wording of the manual-test can be improved...

1.) State that the launcher should be filled with enough sticky (bamf/launcher) icons so the icons collapse in the folding layout and they are forced to expand when in keyboard-navigation.

2.) Note the term "sticky" meaning stickyness within the scope of bamf/launcher and not window workspace-stickyness. That way testers are not confused when reading through and reproducing the manual tests.

review: Needs Fixing

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2012-01-14:

Manual test fixed as requested, so: approving the branch for merging.

Revision history for this message

Unity Merger (unity-merger) wrote on 2012-01-14:

Attempt to merge into lp:unity failed due to conflicts:

text conflict in plugins/unityshell/src/unityshell.cpp