Merge lp://qastaging/~3v1n0/unity/ups-fix-a11y-entry-crash into lp://qastaging/unity
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Didier Roche-Tolomelli |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2145 |
| Proposed branch: | lp://qastaging/~3v1n0/unity/ups-fix-a11y-entry-crash |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
52 lines (+16/-3) 3 files modified
manual-tests/PanelService.txt (+12/-0) services/panel-indicator-entry-accessible.c (+3/-2) services/panel-service.c (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/ups-fix-a11y-entry-crash |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Didier Roche-Tolomelli | Approve | ||
|
Review via email:
|
|||
Commit message
unity-panel-
Entries with invalid parent_object have been removed from the indicator
so we shouldn't really care about them.
Description of the change
PanelindicatorE
Entries with invalid parent_object have been removed from the indicator
so we shouldn't really care about them. It's up to the single indicators to correctly emit the entry-added/removed signals, but the panel service shouldn't be so fragile to crash if these entries are no longer valid.
To post a comment you must log in.
Revision history for this message
| Tim Penhey (thumper) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The code looks fine. Can we look to get the test from the bug report into the test suite please?