libmemcached

Merge lp://qastaging/~493pocbrcycmdw7yksonho9o2qzz-o18bz-d18ecat4t1b76tkfi3vttrkfngli/libmemcached/feature-server_timeout into lp://qastaging/libmemcached/1.0

  1. feature-server_timeout
  2. Merge into 1.0
Proposed by Massive Media
Status: Needs review
Proposed branch: lp://qastaging/~493pocbrcycmdw7yksonho9o2qzz-o18bz-d18ecat4t1b76tkfi3vttrkfngli/libmemcached/feature-server_timeout
Merge into: lp://qastaging/libmemcached/1.0
Diff against target: 227 lines (+50/-18)
13 files modified
libmemcached-1.0/defaults.h (+1/-1)
libmemcached-1.0/struct/memcached.h (+1/-0)
libmemcached-1.0/struct/server.h (+2/-0)
libmemcached-1.0/types/behavior.h (+1/-0)
libmemcached/behavior.cc (+7/-0)
libmemcached/connect.cc (+1/-0)
libmemcached/instance.cc (+2/-0)
libmemcached/instance.hpp (+3/-0)
libmemcached/memcached.cc (+2/-0)
libmemcached/quit.cc (+1/-0)
libmemcached/server.cc (+2/-0)
libmemcached/server.hpp (+26/-17)
tests/libmemcached-1.0/mem_functions.cc (+1/-0)
To merge this branch: bzr merge lp://qastaging/~493pocbrcycmdw7yksonho9o2qzz-o18bz-d18ecat4t1b76tkfi3vttrkfngli/libmemcached/feature-server_timeout
Reviewer Review Type Date Requested Status
Brian Aker Approve
Maurus Cuelenaere (community) Approve
Tangent Trunk Pending
Review via email: mp+195974@code.qastaging.launchpad.net

Description of the change

Added server_timeout_counter and behavior MEMCACHED_BEHAVIOR_SERVER_TIMEOUT_LIMIT.

This feature works as follows:
When a timeout occurs, retry MEMCACHED_BEHAVIOR_SERVER_TIMEOUT_LIMIT times before
putting the server in MEMCACHED_SERVER_STATE_IN_TIMEOUT state.

It makes sense to not fail from the 1st time but retry on the next calls before marking
the server as timeout. Since the default is 0 (don't retry first before marking as TIMEOUT) it will be backwards compatible.

To post a comment you must log in.
Revision history for this message
Maurus Cuelenaere (mcuelenaere) wrote :

LGTM

review: Approve
Reply
Revision history for this message
Brian Aker (brianaker) wrote :

This has been merged.

review: Approve
Reply

Unmerged revisions

1173. By nicolas

Added server_timeout_counter and behavior MEMCACHED_BEHAVIOR_SERVER_TIMEOUT_LIMIT.

This feature works as follows:
When a timeout occurs, retry MEMCACHED_BEHAVIOR_SERVER_TIMEOUT_LIMIT times before
putting the server in MEMCACHED_SERVER_STATE_IN_TIMEOUT state.

It makes sense to not fail from the 1st time but retry on the next calls before marking
the server as timeout.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: