Merge lp://qastaging/~aacid/bamf-qt/constref into lp://qastaging/bamf-qt

Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 396
Merged at revision: 398
Proposed branch: lp://qastaging/~aacid/bamf-qt/constref
Merge into: lp://qastaging/bamf-qt
Diff against target: 129 lines (+10/-10)
10 files modified
bamf-application.cpp (+1/-1)
bamf-application.h (+1/-1)
bamf-factory.cpp (+1/-1)
bamf-factory.h (+1/-1)
bamf-indicator.cpp (+1/-1)
bamf-indicator.h (+1/-1)
bamf-view.cpp (+1/-1)
bamf-view.h (+1/-1)
bamf-window.cpp (+1/-1)
bamf-window.h (+1/-1)
To merge this branch: bzr merge lp://qastaging/~aacid/bamf-qt/constref
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+103080@code.qastaging.launchpad.net

Commit message

Add const & to some parameters

Avoids a copy of each object. It is true that most of those objects are
implicitly shared so the win isn't huge but we still save some atomic/mutex/something locking

Description of the change

Add const & to some parameters

Avoids a copy of each object. It is true that most of those objects are
implicitly shared so the win isn't huge but we still save some atomic/mutex/something locking

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches