Bluetooth Menu

Merge lp://qastaging/~aacid/indicator-bluetooth/fix_autostart into lp://qastaging/indicator-bluetooth/14.10

  1. fix_autostart
  2. Merge into trunk.14.10
Proposed by Albert Astals Cid
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp://qastaging/~aacid/indicator-bluetooth/fix_autostart
Merge into: lp://qastaging/indicator-bluetooth/14.10
Diff against target: 23 lines (+2/-0)
2 files modified
data/indicator-bluetooth.desktop.in (+1/-0)
data/indicator-bluetooth.upstart.desktop.in (+1/-0)
To merge this branch: bzr merge lp://qastaging/~aacid/indicator-bluetooth/fix_autostart
Reviewer Review Type Date Requested Status
Dmitry Shachnev Needs Fixing
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+229324@code.qastaging.launchpad.net

Commit message

Make it only start in Unity like the rest of indicators

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:84
http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-ci/36/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-utopic-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-utopic-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-utopic-armhf-ci/2/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-bluetooth-ci/36/rebuild

review: Approve (continuous-integration)
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

As I said on IRC, "OnlyShowIn: unity" is wrong. Indicators should *not* be started in Unity via xdg autostart, as they are started via upstart.

Xubuntu and GNOME Flashback are using upstart jobs as well, so maybe we don't need this desktop file at all:

https://launchpad.net/ubuntu/+source/xfce4-indicator-plugin/2.3.2-0ubuntu2
https://launchpad.net/ubuntu/+source/gnome-panel/1:3.8.0-1ubuntu9

review: Needs Fixing
Revision history for this message
Albert Astals Cid (aacid) wrote :

Do you then want me to propose a merge removing this file altogether?

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Looks like I answered your question on IRC but not here:

I think removing that file is the right way to go, but better get someone else to confirm it.

Revision history for this message
Albert Astals Cid (aacid) wrote :

It's obvious the world doesn't care, i'll reject this myself, at least my merge queue will be cleaner.

Unmerged revisions

84. By Albert Astals Cid

Make it only start in Unity like the rest of indicators

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches