Merge lp://qastaging/~aacid/ubuntu-ui-toolkit/anchors_cant_be_null into lp://qastaging/ubuntu-ui-toolkit/staging

Proposed by Albert Astals Cid
Status: Merged
Approved by: Zsombor Egri
Approved revision: 2181
Merged at revision: 2181
Proposed branch: lp://qastaging/~aacid/ubuntu-ui-toolkit/anchors_cant_be_null
Merge into: lp://qastaging/ubuntu-ui-toolkit/staging
Diff against target: 14 lines (+2/-2)
1 file modified
src/imports/Components/ListItems/1.3/ThinDivider.qml (+2/-2)
To merge this branch: bzr merge lp://qastaging/~aacid/ubuntu-ui-toolkit/anchors_cant_be_null
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+318450@code.qastaging.launchpad.net

Commit message

ThinDivider: Anchors can't be null, set to undefined

Description of the change

Fix warning we get sometimes in unity8
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/ListItems/1.3/ThinDivider.qml:51:16: Unable to assign null to QQuickAnchorLine

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Fair point on null->undefined! Thanks for the fix!

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches