unity-2d

Merge lp://qastaging/~aacid/unity-2d/dash_tab_handling into lp://qastaging/unity-2d

  1. dash_tab_handling
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 1061
Merged at revision: 1066
Proposed branch: lp://qastaging/~aacid/unity-2d/dash_tab_handling
Merge into: lp://qastaging/unity-2d
Diff against target: 508 lines (+334/-2)
12 files modified
libunity-2d-private/src/focuspath.cpp (+35/-1)
libunity-2d-private/src/focuspath.h (+6/-0)
shell/dash/Dash.qml (+32/-0)
shell/dash/Filter.qml (+3/-0)
shell/dash/FilterCheckoption.qml (+4/-0)
shell/dash/FilterLoader.qml (+6/-0)
shell/dash/FilterPane.qml (+44/-0)
shell/dash/LensView.qml (+24/-0)
shell/dash/ListViewWithHeaders.qml (+51/-1)
shell/dash/ListViewWithScrollbar.qml (+20/-0)
shell/dash/RendererGrid.qml (+8/-0)
tests/manual-tests/dash.txt (+101/-0)
To merge this branch: bzr merge lp://qastaging/~aacid/unity-2d/dash_tab_handling
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+101355@code.qastaging.launchpad.net

Commit message

[Dash] Handle Tab and Shift+Tab to navigate between the headers

Description of the change

[Dash] Handle Tab and Shift+Tab to navigate between the headers
UNBLOCK

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

Still WIP (thought it mostly works) and missing tests but I'd like to know if you think this is the way to go

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Can we get rid of console.log? I found only 8 occurences of it in our existing code, only for critical issues (well, except for 2 debug statements in VisibilityController.qml ;)).

Revision history for this message
Albert Astals Cid (aacid) wrote :

Well, the console.log are there to signal a critical problem, if you got there something went very wrong as the focus is in an unexpected place and tab won't work. In my opinion if that ever happens it will help us a lot of the user having the problem can see it.

Revision history for this message
Gerry Boland (gerboland) wrote :

Tests are correct, code correctly offers behaviours as defined in bug report.

Some UI elements not reacting to focus change, need fix for bug 893966 to resolve that (in progress).

I approve of this change as it resolves a big UX delta with Unity. SRU required before merging however.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

Attempt to merge into lp:unity-2d failed due to conflicts:

text conflict in tests/manual-tests/dash.txt

lp://qastaging/~aacid/unity-2d/dash_tab_handling updated
1061. By Albert Astals Cid

Merge lp:unity-2d

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches