unity-2d

libunity-2d-private/src/inputshaperectangle.cpp (+16/-1)
libunity-2d-private/src/inputshaperectangle.h (+4/-0)
shell/Shell.qml (+27/-9)
shell/app/shelldeclarativeview.cpp (+18/-5)
shell/app/shelldeclarativeview.h (+1/-0)
shell/common/utils.js (+8/-0)
shell/dash/HomeShortcuts.qml (+7/-0)
shell/launcher/IntelliHideBehavior.qml (+18/-4)
shell/launcher/Launcher.qml (+2/-6)
shell/launcher/LauncherLoader.qml (+8/-0)
tests/getshape/getshape.cpp (+33/-4)
tests/launcher/autohide_show_tests.rb (+2/-2)
tests/launcher/autohide_show_tests_rtl.rb (+15/-15)
tests/shell/input_shaping.rb (+15/-159)
tests/shell/input_shaping_common.rb (+180/-0)
tests/shell/input_shaping_rtl.rb (+92/-0)

To merge this branch:

bzr merge lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl

Undecided

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Gerry Boland (community)	2012-01-27	Approve on 2012-02-06
Michał Sawicz	2012-01-27	Abstain on 2012-02-03
Lohith D Shivamurthy (community)	2012-01-27	Needs Information on 2012-01-31
Review via email: mp+90455@code.qastaging.launchpad.net

Description of the change

[shell] Bring back shell to the level of RTL that current unity-2d has

Everything i can find that is missing RTL wise now seems to be fixed at https://code.launchpad.net/~haggai-eran/unity-2d/rtl-rebased/+merge/82151

Revision history for this message

Michał Sawicz (saviq) wrote on 2012-01-27:

The dash corner input mask needs to be moved and flipped horizontally.

review: Needs Fixing

lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl updated on 2012-01-27

942. By Albert Astals Cid on 2012-01-27: These comments were MIA for some reason D

Revision history for this message

Gerry Boland (gerboland) wrote on 2012-01-27:

Lots of your tests fail for people on MM setups, because the TmpWindow you open at (XDo::XWindow.display_geometry[0] - 10,100) is shoved to the next monitor by Metacity, and so don't overlap the Launcher.

Could you do the maths like in test "Move window positioning to check launcher action" as that one works perfectly.

Also some of your comments don't match what's going on, e.g.:

+ # Open Terminal with position 40x100
+ xid = TmpWindow.open_window_at(XDo::XWindow.display_geometry[0] - 40, 100)

Aside from these things, everything looks good!

review: Needs Fixing

lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl updated on 2012-01-30

943. By Albert Astals Cid on 2012-01-30

Use a different way to overlap the windows with the launcher, should work on multimonitor according to Gerry

944. By Albert Astals Cid on 2012-01-30

Return the image with the whole desktop size

945. By Albert Astals Cid on 2012-01-30

adapt to new getshape output

946. By Albert Astals Cid on 2012-01-30

merge

947. By Albert Astals Cid on 2012-01-30

Add a workaround for home shortcuts in rtl, need it so tests pass since need to click on the [x] button

948. By Albert Astals Cid on 2012-01-30

Implement mirroring

It can be made more performant but works for now

949. By Albert Astals Cid on 2012-01-30

Add the shaping rtl tests

950. By Albert Astals Cid on 2012-01-30

Use sut and other small other tools from xdotool

951. By Albert Astals Cid on 2012-01-30

Output the file in stdout if outputfilename is -

952. By Albert Astals Cid on 2012-01-30

Make getshape work in target/host divide

953. By Albert Astals Cid on 2012-01-30

Fix anchoring in rtl

954. By Albert Astals Cid on 2012-01-30

Abstract shaping tests, they are the same wheter rtl or not, just one extra if, no need to copy the code twice

955. By Albert Astals Cid on 2012-01-30

Tauler -> Dash home

956. By Albert Astals Cid on 2012-01-30

Add header

957. By Albert Astals Cid on 2012-01-30

abstract stuff so we don't have almost the same code twice

958. By Albert Astals Cid on 2012-01-30

Make it work from run-tests.rb

959. By Albert Astals Cid on 2012-01-30

Remove one space too many

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-01-30:

Ok, i think it is ready to be reviewed again, all comments are fixed (i hope :D)

Revision history for this message

Lohith D Shivamurthy (dyams) wrote on 2012-01-31:

Hey, In his branch Haggai has swapped the left-right cursor keys while navigating in Dash. It is RTL requirement i believe.

review: Needs Information

Revision history for this message

Lohith D Shivamurthy (dyams) wrote on 2012-01-31:

Hey, it works great overall. :)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-01-31:

@Lohith: This does not try to fix ALL of the RTL issues, just makes the shell work as unity-2d non-shell was working, as I say in the description most of Haggai's patch is still needed.

Revision history for this message

Michał Sawicz (saviq) wrote on 2012-01-31:

Wow that's a huge work on the tests, kudos!

One thing I noticed from the diff - instead of commenting out the printf(), maybe you could write it to stderr? Or just drop that line completely.

review: Needs Fixing

lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl updated on 2012-01-31

960. By Albert Astals Cid on 2012-01-31: Drop the printf as suggested in the MR

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-01-31:

I've dropped the printf since execute_shell_command also returns what is written to stderr.

lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl updated on 2012-02-01

961. By Albert Astals Cid on 2012-01-31: merge
962. By Albert Astals Cid on 2012-02-01: merge

Revision history for this message

Gerry Boland (gerboland) wrote on 2012-02-01:

Could you please my name from the copyright notices please?

The input_shaping tests needs small fixes:
- please rename input_shaping_tests.rb to input_shaping_common.rb
- please fix the require path to shell/input_shaping_common.rb. It's currently pointing to autohide stuff for the launcher.
- could you also please change
verify_true(10, "The actual shape does not match the expected shape") { identical }
to assert statements? If identical is false, it will wait 10 seconds before throwing a fail.

review: Needs Fixing

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-02-01:

Removed the names of the copyright notices, except a few ones that will come once https://code.launchpad.net/~aacid/unity-2d/unity-2d_tests_for_rtl/+merge/90849 is merged (and this one will ultraconflict with it)

Also instead of changing to "assert" changed to "verify_true(0," that was an easier change, hope you're ok with that.

lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl updated on 2012-02-01

963. By Albert Astals Cid on 2012-02-01: Fixes comming for the MR discussion

Revision history for this message

Michał Sawicz (saviq) wrote on 2012-02-02:

* Launcher.qml
  * please move the monitoredArea Binding up into LauncherLoader.qml
* input_shaping.rb
  * you removed the Authors completely, was that on purpose?
  * we need to kill panel twice, too
  * @@panel args are not indented properly

review: Needs Fixing

Revision history for this message

Michał Sawicz (saviq) wrote on 2012-02-03:

* input_shaping.rb
* wrong path to autohide_show_tests_common.rb

Revision history for this message

Michał Sawicz (saviq) wrote on 2012-02-03:

We need to wait for https://code.launchpad.net/~aacid/unity-2d/unity-2d_tests_for_rtl/+merge/90849 to be merged first and rebase this afterwards.

review: Abstain

lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl updated on 2012-02-03

964. By Albert Astals Cid on 2012-02-03: merge
965. By Albert Astals Cid on 2012-02-03: fix path
966. By Albert Astals Cid on 2012-02-03: Kill panel twice and indent second line of args for @@panel better

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-02-03:

Requested fixes implemented

lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl updated on 2012-02-03

967. By Albert Astals Cid on 2012-02-03: Move the monitoredArea binding up to LauncherLoader
968. By Albert Astals Cid on 2012-02-03: merge

Revision history for this message

Albert Astals Cid (aacid) wrote on 2012-02-06:

The merge for "tests/launcher/autohide_show_tests_common.rb" and the rtl version look crazy, something is getting confused here, have a look at the individual commits (i.e. r969) to see what is happening there.

lp://qastaging/~aacid/unity-2d/unity-2d-shell_rtl updated on 2012-02-06