lp://qastaging/~aacid/unity-scopes-shell/misc_fixes
- Get this branch:
- bzr branch lp://qastaging/~aacid/unity-scopes-shell/misc_fixes
Branch merges
- Marcus Tomlinson (community): Approve
- unity-api-1-bot: Approve (continuous-integration)
-
Diff: 89 lines (+5/-8)7 files modifiedsrc/Unity/optionselectoroptions.h (+1/-1)
src/Unity/overviewscope.cpp (+1/-1)
src/Unity/settingsmodel.cpp (+0/-1)
src/scope-harness/preview/preview-widget.h (+1/-1)
tests/data/mock-scope-departments/mock-scope-departments.cpp (+1/-1)
tests/data/mock-scope/mock-scope.cpp (+1/-1)
tests/resultstest.cpp (+0/-2)
Branch information
Recent revisions
- 356. By Albert Astals Cid
-
Misc fixes
preview-widget.h
optionselectoroptions. h
Forward declare as struct as it is really a struct when definedoverviewscope.cpp
Save creating a list with all the values since foreach knows how to properly iterate a map/hashsettingsmodel.cpp
resultstest.cpp
Don't create an object we never usemock-scope-
departments. cpp
/mock-scope.cpp
Mark function as override - 352. By Michael Terry
-
Handle running inside a snap by paying attention to the $SNAP prefix. (LP: #1629009)
Approved by: Marcus Tomlinson, unity-api-1-bot
- 349. By Marcus Tomlinson
-
Don't make changes to the settings model from a separate thread. (LP: #1627795)
- 348. By Albert Astals Cid
-
Save creating/destroying a QSharedPointer
It's not much but it's a free optimization anyway
Approved by: Paweł Stołowski
- 347. By Albert Astals Cid
-
Optimize ResultsModel::data a bit
Do the role to component string early in ::setComponents
Mapping instead of every time in ::data
This way we do not need to create temporary strings every time ::data gets calledAlso since we know there's a finite amount of roles, store the role->string mapping in a vector instead of a map/hash
Approved by: Marcus Tomlinson
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://qastaging/unity-scopes-shell