Merge lp://qastaging/~aacid/unity/launcher_selection_changed_fix_1067358 into lp://qastaging/unity
Proposed by
Albert Astals Cid
Status: | Merged |
---|---|
Approved by: | Marco Trevisan (Treviño) |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2848 |
Proposed branch: | lp://qastaging/~aacid/unity/launcher_selection_changed_fix_1067358 |
Merge into: | lp://qastaging/unity |
Diff against target: |
209 lines (+69/-9) 9 files modified
launcher/AbstractLauncherIcon.h (+1/-0) launcher/LauncherController.cpp (+18/-6) launcher/LauncherControllerPrivate.h (+2/-0) launcher/LauncherIcon.cpp (+5/-0) launcher/LauncherIcon.h (+1/-0) launcher/MockLauncherIcon.h (+4/-0) launcher/QuicklistView.cpp (+8/-3) launcher/QuicklistView.h (+1/-0) tests/test_launcher_controller.cpp (+29/-0) |
To merge this branch: | bzr merge lp://qastaging/~aacid/unity/launcher_selection_changed_fix_1067358 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Trevisan (Treviño) | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+129923@code.qastaging.launchpad.net |
Commit message
Update the UBUS_LAUNCHER_
Description of the change
Update the UBUS_LAUNCHER_
To post a comment you must log in.
Hey, to reply to your IRC question, it would be nice to have tests... It should be quite trivial to test this. Just add a test case to test_launcher_ controller, where you check that the ubus message has been sent registering for that selection change.