Merge lp://qastaging/~aacid/unity8/alt_tab_close_top_menu into lp://qastaging/unity8
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp://qastaging/~aacid/unity8/alt_tab_close_top_menu | ||||
Merge into: | lp://qastaging/unity8 | ||||
Prerequisite: | lp://qastaging/~aacid/unity8/stray_menus | ||||
Diff against target: |
225 lines (+68/-34) 7 files modified
qml/Panel/Panel.qml (+8/-8) qml/Shell.qml (+1/-0) qml/Stage/DecoratedWindow.qml (+1/-0) qml/Stage/Stage.qml (+2/-1) qml/Stage/WindowDecoration.qml (+1/-0) tests/qmltests/Panel/tst_Panel.qml (+3/-25) tests/qmltests/tst_Shell.qml (+52/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~aacid/unity8/alt_tab_close_top_menu | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Approve | |
Daniel d'Andrada (community) | Approve | ||
Review via email:
|
This proposal has been superseded by a proposal from 2017-04-03.
Commit message
Close top bar menu on alt+tab
Includes test that checks it works (and checks focus doesn't get lost in the middle of nowhere later)
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
Unmerged revisions
- 2879. By Albert Astals Cid
-
mrege again
- 2878. By Albert Astals Cid
-
Adapt to code changes, now it's mostly a test
- 2877. By Albert Astals Cid
- 2876. By Albert Astals Cid
-
try to find a non conflicting place ^_^
- 2875. By Albert Astals Cid
-
Merge
- 2874. By Albert Astals Cid
-
Need to wait a bit
- 2873. By Albert Astals Cid
-
whitespace
- 2872. By Albert Astals Cid
-
Merge
- 2871. By Albert Astals Cid
-
Move the check for no popup to before releasing alt
- 2870. By Albert Astals Cid
-
Use the mouse to show the menu
PASSED: Continuous integration, rev:2869 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3371/ /unity8- jenkins. ubuntu. com/job/ build/4443 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= xenial+ overlay, testname= qmluitests. sh/2662 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= zesty,testname= qmluitests. sh/2662 /unity8- jenkins. ubuntu. com/job/ build-0- fetch/4471 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 4301 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 4301/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= zesty/4301 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= zesty/4301/ artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 4301 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 4301/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= zesty/4301 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= zesty/4301/ artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 4301 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 4301/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= zesty/4301 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= zesty/4301/ artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3371/ rebuild
https:/