Merge lp://qastaging/~aacid/unity8/complainRegisterServiceFails into lp://qastaging/unity8
Proposed by
Albert Astals Cid
| Status: | Merged |
|---|---|
| Approved by: | Michał Sawicz |
| Approved revision: | 2839 |
| Merged at revision: | 2861 |
| Proposed branch: | lp://qastaging/~aacid/unity8/complainRegisterServiceFails |
| Merge into: | lp://qastaging/unity8 |
| Diff against target: |
29 lines (+5/-2) 1 file modified
plugins/Utils/URLDispatcher.cpp (+5/-2) |
| To merge this branch: | bzr merge lp://qastaging/~aacid/unity8/complainRegisterServiceFails |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lukáš Tinkl (community) | Approve | ||
| Unity8 CI Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Add warning if registerService fails
Coverity argues we do that in the rest of calls so be consistent
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
N/A
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:2838
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/