Merge lp://qastaging/~aacid/unity8/mapToItem3Args into lp://qastaging/unity8
Proposed by
Albert Astals Cid
| Status: | Merged |
|---|---|
| Approved by: | Michael Zanetti |
| Approved revision: | 2549 |
| Merged at revision: | 2550 |
| Proposed branch: | lp://qastaging/~aacid/unity8/mapToItem3Args |
| Merge into: | lp://qastaging/unity8 |
| Diff against target: |
34 lines (+3/-3) 2 files modified
qml/Launcher/LauncherPanel.qml (+1/-1) tests/qmltests/Stages/tst_PhoneStage.qml (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~aacid/unity8/mapToItem3Args |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Zanetti (community) | Approve | ||
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Pass the correct number of arguments to mapToItem
One argument used to work in Qt 5.4 and 5.5 but it is not documented and seems to have broken on Qt 5.6 so just update to the correct signature
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
lgtm. I've often made that very same mistake before and also already fixed a few occurances of this.
I've tested the code change on a current device, no breakage.
waiting for jenkins to confirm tests are passing still with all versions we support.