Merge lp://qastaging/~aacid/unity8/select_first_submenu_when_it_appears into lp://qastaging/unity8
| Status: | Merged |
|---|---|
| Approved by: | Lukáš Tinkl |
| Approved revision: | 2841 |
| Merged at revision: | 2889 |
| Proposed branch: | lp://qastaging/~aacid/unity8/select_first_submenu_when_it_appears |
| Merge into: | lp://qastaging/unity8 |
| Prerequisite: | lp://qastaging/~aacid/unity8/menutool |
| Diff against target: |
289 lines (+94/-28) 6 files modified
qml/ApplicationMenus/MenuBar.qml (+2/-5) qml/ApplicationMenus/MenuPopup.qml (+11/-5) tests/mocks/QMenuModel/unitymenumodel.cpp (+23/-4) tests/mocks/QMenuModel/unitymenumodel.h (+7/-0) tests/qmltests/ApplicationMenus/tst_MenuBar.qml (+34/-0) tests/qmltests/ApplicationMenus/tst_MenuPopup.qml (+17/-14) |
| To merge this branch: | bzr merge lp://qastaging/~aacid/unity8/select_first_submenu_when_it_appears |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lukáš Tinkl (community) | Approve | ||
| Unity8 CI Bot | continuous-integration | Approve | |
| Michael Zanetti | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2017-02-22.
Commit message
Fix real world submenus (e.g. kate) not getting their first item selected on open
MenuBar.qml: remove unused function
MenuPopup.qml: Select first item when one arrives if there's no currentItem instead of on completion
unitymenumodel.cpp: trick rowCount() to simulate "real world late" menus
tst_MenuPopup.qml: adapt to unitymenumodel.cpp changes (and make the Up test actually press Up and not Down)
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
https:/
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Albert Astals Cid (aacid) wrote | # |
| Lukáš Tinkl (lukas-kde) wrote | # |
It does improve the situation but there is something odd:
again, using kate as an example, opening the Tools menu, navigate down to a submenu, enter it, navigate down to the third entry, press left, go to another submenu, enter it. Now the highlight will be at the third entry instead of starting at the first again.
also I managed to get into the situation where I lost keyboard focus altogether in the menu by navigating through the main menu entries. While I'm not 100% sure that is introduced by this branch, I haven't seen it in trunk so far.