Merge lp://qastaging/~aacid/unity8/spacier_drawer into lp://qastaging/unity8
Proposed by
Albert Astals Cid
Status: | Merged |
---|---|
Approved by: | Lukáš Tinkl |
Approved revision: | 2917 |
Merged at revision: | 2920 |
Proposed branch: | lp://qastaging/~aacid/unity8/spacier_drawer |
Merge into: | lp://qastaging/unity8 |
Diff against target: |
101 lines (+44/-3) 2 files modified
qml/Launcher/Drawer.qml (+43/-2) tests/mocks/Unity/Launcher/MockAppDrawerModel.cpp (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~aacid/unity8/spacier_drawer |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lukáš Tinkl (community) | Approve | ||
Unity8 CI Bot | continuous-integration | Approve | |
Review via email:
|
Commit message
Tweak app drawer a bit
Make delegates a bit wider to have more breath space
Add a "tooltip" on hover for delegates whose text is truncated
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the UI, has there been a design review?
No, needs one?
To post a comment you must log in.
Code looks good but could you get rid of the hardcoded colors?
color: UbuntuColors.jet
border.color: UbuntuColors.blue