Merge lp://qastaging/~aacid/unity8/verticalJournalBug1599754 into lp://qastaging/unity8
Proposed by
Albert Astals Cid
| Status: | Merged |
|---|---|
| Approved by: | Michał Sawicz |
| Approved revision: | 2530 |
| Merged at revision: | 2566 |
| Proposed branch: | lp://qastaging/~aacid/unity8/verticalJournalBug1599754 |
| Merge into: | lp://qastaging/unity8 |
| Diff against target: |
179 lines (+89/-2) 5 files modified
plugins/Dash/abstractdashview.cpp (+13/-0) plugins/Dash/abstractdashview.h (+2/-1) plugins/Dash/verticaljournal.cpp (+9/-1) plugins/Dash/verticaljournal.h (+3/-0) tests/plugins/Dash/verticaljournaltest.cpp (+62/-0) |
| To merge this branch: | bzr merge lp://qastaging/~aacid/unity8/verticalJournalBug1599754 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Michał Sawicz | Approve | ||
|
Review via email:
|
|||
Commit message
VerticalJournal improvements regarding model insertions and item height changes
insertions in the middle need to trigger a reset
Item height changes need to trigger a relayout
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Michał Sawicz (saviq) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
* Did you perform an exploratory manual test run of the code change and any related functionality?
Y
* Did CI run pass? If not, please explain why.
Waiting