Merge lp://qastaging/~abentley/bzr-pqm/config-stack-fixes into lp://qastaging/bzr-pqm

Proposed by Aaron Bentley
Status: Merged
Approved by: Martin Packman
Approved revision: 90
Merged at revision: 90
Proposed branch: lp://qastaging/~abentley/bzr-pqm/config-stack-fixes
Merge into: lp://qastaging/bzr-pqm
Diff against target: 56 lines (+7/-3)
3 files modified
pqm_submit.py (+4/-1)
tests/test_lpland.py (+2/-1)
tests/test_pqm_submit.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~abentley/bzr-pqm/config-stack-fixes
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
Review via email: mp+96233@code.qastaging.launchpad.net

Commit message

Fix config use for bzr 2.3-2.6dev

Description of the change

This branch fixes the use of configuration. It restores compatibility with 2.4 and earlier by wrapping config stack access. It restores compatibility with bzr.dev by working around bug #948344.

I've run the test suite with bzr 2.3-bzr.dev r6480

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Extending an using the compat wrapper like this looks fine. Would perhaps be neatest to pull the wrapper logic out of the pqm_submit module but doesn't need to happen here.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: