Merge lp://qastaging/~abentley/bzr-pqm/fix-lp-land into lp://qastaging/bzr-pqm
Proposed by
Aaron Bentley
| Status: | Merged |
|---|---|
| Merged at revision: | 85 |
| Proposed branch: | lp://qastaging/~abentley/bzr-pqm/fix-lp-land |
| Merge into: | lp://qastaging/bzr-pqm |
| Diff against target: |
398 lines (+216/-47) 5 files modified
__init__.py (+3/-4) lpland.py (+42/-25) pqm_submit.py (+44/-9) tests/test_lpland.py (+119/-9) tests/test_pqm_submit.py (+8/-0) |
| To merge this branch: | bzr merge lp://qastaging/~abentley/bzr-pqm/fix-lp-land |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix lp-land.
Description of the change
Recent changes to config handling broke lp-land. This breakage was not detected because lp-land was not sufficiently tested.
This branch fixes the breakage by using an implementation of config.Stack as the input to pqm_email.
It increases the test coverage of lp-land to reduce the chance of similar problems in the future.
It changes the behaviour of ConfigStack.get so that it supports environment variables such as BZR_EMAIL and EMAIL.
It extracts get_stacked_config and get_mail_from to increase code re-use.
It moves most functionality out of Submitter.__init__ into the new from_cmdline factory method, to make testing easier.
It extracts Submitter.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Not much to add, nice cleanup!