Merge lp://qastaging/~abentley/launchpad/build-duration into lp://qastaging/launchpad/db-devel
| Status: | Merged |
|---|---|
| Merged at revision: | 9627 |
| Proposed branch: | lp://qastaging/~abentley/launchpad/build-duration |
| Merge into: | lp://qastaging/launchpad/db-devel |
| Diff against target: |
231 lines (+43/-20) 9 files modified
database/sampledata/current-dev.sql (+9/-1) database/sampledata/current.sql (+9/-1) database/schema/patch-2207-75-0.sql (+9/-0) lib/lp/buildmaster/tests/test_buildfarmjob.py (+1/-0) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+4/-2) lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+3/-1) lib/lp/soyuz/doc/binarypackagebuild.txt (+3/-1) lib/lp/soyuz/stories/soyuz/xx-builds-pages.txt (+4/-4) lib/lp/soyuz/tests/test_binarypackagebuild.py (+1/-10) |
| To merge this branch: | bzr merge lp://qastaging/~abentley/launchpad/build-duration |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Edwin Grubbs (community) | code | Approve | |
| Stuart Bishop (community) | db | Approve | |
| Robert Collins | db | Pending | |
|
Review via email:
|
|||
Description of the change
= Summary =
Fix bug #612899: Some recipe builds have NULL date_started but non-NULL date_finished
== Proposed fix ==
Fix the broken production data before migration by using the
date_first_
build_duration.
Add a constraint to ensure this bug doesn't re-surface.
== Pre-implementation notes ==
Discussed with bigjools
== Implementation details ==
Some of the sampledata was broken, so I fixed it.
== Tests ==
None
== Demo and Q/A ==
None
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
database/
database/
database/
./database/
7: Line exceeds 78 characters.
10: Line exceeds 78 characters.
12: Line exceeds 78 characters.
15: Line exceeds 78 characters.
18: Line exceeds 78 characters.
| Aaron Bentley (abentley) wrote | # |
The change looks fine. Note that updating the existing db patch means it will not have effect on staging until the next full database restore (hopefully this weekend).