Merge lp://qastaging/~abentley/simplestreams/allow-no-size into lp://qastaging/simplestreams
Proposed by
Aaron Bentley
| Status: | Merged |
|---|---|
| Merged at revision: | 438 |
| Proposed branch: | lp://qastaging/~abentley/simplestreams/allow-no-size |
| Merge into: | lp://qastaging/simplestreams |
| Diff against target: |
34 lines (+13/-1) 2 files modified
simplestreams/json2streams.py (+3/-1) tests/unittests/test_json2streams.py (+10/-0) |
| To merge this branch: | bzr merge lp://qastaging/~abentley/simplestreams/allow-no-size |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| simplestreams-dev | Pending | ||
|
Review via email:
|
|||
Commit message
json2streams: accept items with no size.
dict_to_item automatically converts size from a string to an int. This
has the side effect of making size mandatory. Size should not be mandatory
for image-ids.
Description of the change
Allow size to be optional.
dict_to_item automatically converts size from a string to an int. But this has the side effect of making size mandatory. But size should not be mandatory for image-ids, so this branch makes it optional.
To post a comment you must log in.
Revision history for this message
| Scott Moser (smoser) wrote | # |
Revision history for this message
| Aaron Bentley (abentley) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
i'll pull this now. in the future, though. please set commit message to git style:
summary
<blank line>
description.
such as what i just set it to here.