Merge lp://qastaging/~abreu-alexandre/oxide/add-device-id-constraint-support-getusermedia into lp://qastaging/~oxide-developers/oxide/oxide.trunk

Proposed by Alexandre Abreu
Status: Merged
Merged at revision: 1453
Proposed branch: lp://qastaging/~abreu-alexandre/oxide/add-device-id-constraint-support-getusermedia
Merge into: lp://qastaging/~oxide-developers/oxide/oxide.trunk
Diff against target: 105 lines (+41/-5)
1 file modified
shared/browser/media/oxide_media_capture_devices_dispatcher.cc (+41/-5)
To merge this branch: bzr merge lp://qastaging/~abreu-alexandre/oxide/add-device-id-constraint-support-getusermedia
Reviewer Review Type Date Requested Status
Chris Coulson Approve
Review via email: mp+291954@code.qastaging.launchpad.net

Commit message

Add support for device id constraint support

Description of the change

Add support for device id constraint support

To post a comment you must log in.
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks, I've added some comments inline

review: Needs Fixing
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Updated

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

(and replied to your comment)

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I've added another reply

review: Needs Fixing
1447. By Alexandre Abreu

Remove requestVideo/Aufio id properties to media request

1448. By Alexandre Abreu

nits

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Updated

Revision history for this message
Chris Coulson (chrisccoulson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches