Merge lp://qastaging/~abreu-alexandre/oxide/add-quota-permission-context-support into lp://qastaging/~oxide-developers/oxide/oxide.trunk
Proposed by
Alexandre Abreu
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~abreu-alexandre/oxide/add-quota-permission-context-support |
Merge into: | lp://qastaging/~oxide-developers/oxide/oxide.trunk |
Diff against target: |
1203 lines (+538/-96) 24 files modified
qt/build/system.gyp (+17/-0) qt/core/api/oxideqpermissionrequest.cc (+50/-0) qt/core/api/oxideqpermissionrequest.h (+22/-0) qt/core/api/oxideqpermissionrequest_p.h (+20/-0) qt/core/browser/oxide_qt_web_view.cc (+32/-0) qt/core/browser/oxide_qt_web_view.h (+5/-0) qt/core/core.gyp (+1/-0) qt/core/glue/oxide_qt_web_view_proxy.h (+2/-0) qt/core/glue/oxide_qt_web_view_proxy_client.h (+4/-0) qt/qmlplugin/oxide.qmltypes (+35/-14) qt/qmlplugin/oxide_qml_plugin.cc (+8/-0) qt/quick/api/oxideqquickwebview.cc (+30/-0) qt/quick/api/oxideqquickwebview.h (+2/-0) qt/quick/api/oxideqquickwebview_p.h (+6/-0) qt/tests/qmltests/TestWebView.qml (+1/-1) qt/tests/qmltests/api/tst_WebView_quotaPermission.html (+49/-0) qt/tests/qmltests/api/tst_WebView_quotaPermission.qml (+202/-0) qt/tests/qmltests/api/tst_WebView_quotaPermission_iframe.html (+5/-0) qt/tests/qmltests/oxide_qml_testing_plugin.cc (+10/-0) shared/browser/oxide_quota_permission_context.cc (+0/-36) shared/browser/oxide_quota_permission_context.h (+0/-45) shared/browser/permissions/oxide_permission_request_dispatcher.cc (+27/-0) shared/browser/permissions/oxide_permission_request_dispatcher.h (+6/-0) shared/browser/permissions/oxide_permission_request_dispatcher_client.h (+4/-0) |
To merge this branch: | bzr merge lp://qastaging/~abreu-alexandre/oxide/add-quota-permission-context-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Coulson | Needs Fixing | ||
Review via email: mp+243351@code.qastaging.launchpad.net |
Commit message
Add support for quota permission context request.
Description of the change
Add support for quota permission context request.
A patch branch for chromium is needed for that change:
To post a comment you must log in.
Unmerged revisions
- 1338. By Alexandre Abreu
-
Tweaks
- 1337. By Alexandre Abreu
-
Add support for quota permission context request.
Thanks for working on this. I've added some comments inline.
This is also lacking tests - I'd start by looking at the geolocation permission tests (and also take in to consideration the points in bug 1399196). Note, cancellation when navigating subframes probably won't work for quota permissions like it should for geolocation (we have no indication of the frame on the browser side).