unity-js-scopes

Merge lp://qastaging/~abreu-alexandre/unity-js-scopes/registry into lp://qastaging/unity-js-scopes

registry
Merge into trunk

Proposed by Alexandre Abreu on 2015-10-19

Status:

Merged

Approved by:

Marcus Tomlinson on 2015-11-02

Approved revision:

103

Merged at revision:

103

Proposed branch:

lp://qastaging/~abreu-alexandre/unity-js-scopes/registry

Merge into:

lp://qastaging/unity-js-scopes

Diff against target:

869 lines (+697/-21)

10 files modified

examples/simple/simple.js (+75/-0)
src/bindings/index.js (+13/-1)
src/bindings/src/addon.cc (+47/-20)
src/bindings/src/registry.cc (+147/-0)
src/bindings/src/registry.h (+121/-0)
src/bindings/src/scope-base.cc (+4/-0)
src/bindings/src/scope-base.h (+4/-0)
src/bindings/src/scope-metadata.h (+132/-0)
src/bindings/src/variant.cc (+102/-0)
src/bindings/src/variant.h (+52/-0)

To merge this branch:

bzr merge lp://qastaging/~abreu-alexandre/unity-js-scopes/registry

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Marcus Tomlinson (community)		2015-10-19	Approve on 2015-11-02
PS Jenkins bot (community)	continuous-integration		Approve on 2015-10-29
Review via email: mp+274942@code.qastaging.launchpad.net

Commit message

Registry API handling

Description of the change

Registry API handling

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-28:

PASSED: Continuous integration, rev:89
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/44/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/45
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/45
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/45/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/44

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/44/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-28:

PASSED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/unity-js-scopes-ci/45/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-amd64-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/46
        deb: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-armhf-ci/46/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-js-scopes-wily-i386-ci/45

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-js-scopes-ci/45/rebuild

review: Approve (continuous-integration)

Revision history for this message

Marcus Tomlinson (marcustomlinson) wrote on 2015-10-29:

These doc updates amongst impl is really horrible. Please could you split this branch into an impl MP and a doc MP? It is really tough to read this diff.

review: Needs Fixing

lp://qastaging/~abreu-alexandre/unity-js-scopes/registry updated on 2015-10-29