unity-webapps-qml

Merge lp://qastaging/~abreu-alexandre/unity-webapps-qml/content-hub-text into lp://qastaging/unity-webapps-qml

  1. content-hub-text
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Merged
Approved by: Ken VanDine
Approved revision: 157
Merged at revision: 153
Proposed branch: lp://qastaging/~abreu-alexandre/unity-webapps-qml/content-hub-text
Merge into: lp://qastaging/unity-webapps-qml
Diff against target: 119 lines (+29/-5)
4 files modified
src/Ubuntu/UnityWebApps/bindings/content-hub/backend/content-hub.js (+14/-2)
src/Ubuntu/UnityWebApps/bindings/content-hub/client/content-hub.js (+6/-0)
tests/unit/test_qml/tst_api_contenthub.html (+6/-1)
tests/unit/test_qml/tst_api_contenthub.qml (+3/-2)
To merge this branch: bzr merge lp://qastaging/~abreu-alexandre/unity-webapps-qml/content-hub-text
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ken VanDine Approve
Review via email: mp+257767@code.qastaging.launchpad.net

Commit message

Add contentitem.text support & ebooks content hub type

Description of the change

Add contentitem.text support & ebooks content hub type

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good and works fine. It can be tested with http://people.canonical.com/~kenvandine/hub-text-exporter.ken-vandine_0.1_all.click

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :

It works great, but I did have a couple nits inline

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:155
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/176/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-vivid-amd64-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-vivid-armhf-ci/30

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/176/rebuild

review: Approve (continuous-integration)
lp://qastaging/~abreu-alexandre/unity-webapps-qml/content-hub-text updated
156. By Alexandre Abreu

nits

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

updated

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:156
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/177/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-vivid-amd64-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-vivid-armhf-ci/31

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/177/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

One more white space issue, commented inline. Otherwise good to go!

review: Needs Fixing
lp://qastaging/~abreu-alexandre/unity-webapps-qml/content-hub-text updated
157. By Alexandre Abreu

nit

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Great!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:157
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/178/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-vivid-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-vivid-armhf-ci/32

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/178/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: