Code review comment for lp://qastaging/~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

To comment on a few notes:

> The type of the parameter for all those three signals should be 'url', not 'string'.

As I said earlier: yes I agree, but I get dbus runtime error on the AP side while trying to marshal the 'url' qml type to the QUrl qt type (unknown to dbus), ...

> this looks unsafe and abuse-prone to me, can’t we devise a more secure way of enabling tests, that doesn’t involve opening a backdoor in the container?

It is tricky to do something clean w/ this. Either way the container needs to run with some context, I did a few updates that makes it a bit cleaner ...

« Back to merge proposal