Code review comment for lp://qastaging/~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup

Revision history for this message
Olivier Tilloy (osomon) wrote :

545 + self.assertThat(lambda: popup_watcher.was_emitted,
546 + Eventually(Equals(popup_should_be_opened)))

In the case where popup_should_be_opened is False (i.e. on devices), I don’t think this test is useful, because popup_watcher.was_emitted is initially False anyway, before it changes to True.
So you probably want to make this assertion conditional instead:

    if popup_should_be_opened:
        self.assertThat(popup_watcher.was_emitted, Eventually(Equals(True)))

« Back to merge proposal