webbrowser-app

Merge lp://qastaging/~abreu-alexandre/webbrowser-app/browser-directory-for-snaps into lp://qastaging/webbrowser-app

  1. browser-directory-for-snaps
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Rejected
Rejected by: Olivier Tilloy
Proposed branch: lp://qastaging/~abreu-alexandre/webbrowser-app/browser-directory-for-snaps
Merge into: lp://qastaging/webbrowser-app
Diff against target: 26 lines (+6/-2)
1 file modified
src/app/config.h.in (+6/-2)
To merge this branch: bzr merge lp://qastaging/~abreu-alexandre/webbrowser-app/browser-directory-for-snaps
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Olivier Tilloy Disapprove
Review via email: mp+304792@code.qastaging.launchpad.net

Commit message

Tweak UbuntuBrowserDirectory to handle snap install launches

Description of the change

Tweak UbuntuBrowserDirectory to handle snap install launches

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

This is essentially the same that I did in my snap branch (https://bazaar.launchpad.net/~osomon/webbrowser-app/snap/revision/1509), so I’d rather not do that in two separate places. I will soon propose that snap branch for merging.

review: Disapprove
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1533
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/623/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1410/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1410
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1269
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1269
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1269
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1266
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1266/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1266
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1266/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1266/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1266
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1266/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1266
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1266/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1266/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1266
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1266/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1266
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1266/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1266/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/623/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

1533. By Alexandre Abreu

Tweak UbuntuBrowserDirectory to handle snap install launches

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: