webbrowser-app

Merge lp://qastaging/~abreu-alexandre/webbrowser-app/container-handle-camera-access into lp://qastaging/webbrowser-app

container-handle-camera-access
Merge into trunk

Proposed by Alexandre Abreu on 2016-03-09

Status:

Merged

Approved by:

Alexandre Abreu on 2016-03-18

Approved revision:

1381

Merged at revision:

1386

Proposed branch:

lp://qastaging/~abreu-alexandre/webbrowser-app/container-handle-camera-access

Merge into:

lp://qastaging/webbrowser-app

Diff against target:

334 lines (+170/-16)

7 files modified

src/app/webcontainer/CMakeLists.txt (+0/-1)
src/app/webcontainer/PopupWindowController.qml (+8/-3)
src/app/webcontainer/PopupWindowOverlay.qml (+16/-1)
src/app/webcontainer/WebViewImplOxide.qml (+30/-9)
src/app/webcontainer/WebappContainerWebview.qml (+11/-2)
tests/autopilot/webapp_container/tests/fake_servers.py (+35/-0)
tests/autopilot/webapp_container/tests/test_media_permission.py (+70/-0)

To merge this branch:

bzr merge lp://qastaging/~abreu-alexandre/webbrowser-app/container-handle-camera-access

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2016-03-17
Olivier Tilloy		2016-03-09	Approve on 2016-03-17
Review via email: mp+288571@code.qastaging.launchpad.net

Commit message

Handle media access request from webcontainer main view and overlay views

Description of the change

Handle media access request from webcontainer main view and overlay views

Revision history for this message

David Barth (dbarth) wrote on 2016-03-10:

Typo in the comment below? I didn't understand the phrase. See inline comment.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-03-10:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2666/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Olivier Tilloy (osomon) wrote on 2016-03-10:

I’m getting 15 failures when running the webapp_container test suite on my desktop. Those are regressions, all tests pass with trunk.

review: Needs Fixing

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2016-03-11:

> Typo in the comment below? I didn't understand the phrase. See inline comment.

updated

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-03-11:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2668/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2016-03-11:

> I’m getting 15 failures when running the webapp_container test suite on my
> desktop. Those are regressions, all tests pass with trunk.

ok I managed to repro the crashes, I was using an stable version of oxide, with 1.13.6 I get the crash,

The crash goes away as soon as I remove the onMediaAccessPermissionRequested slot,

the stack trace is not very clean yet,

#0 0x00007fd4aa49cfd4 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#1 0x00007fd4aa47d1c9 in QV4::MemoryManager::mark() () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#2 0x00007fd4aa47dc0b in QV4::MemoryManager::runGC() () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#3 0x00007fd4aa47ed98 in QV4::MemoryManager::allocData(unsigned long, unsigned long) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#4 0x00007fd4aa464c6a in QV4::ExecutionEngine::newString(QString const&) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#5 0x00007fd4aa49e094 in QV4::Heap::FunctionObject::FunctionObject(QV4::ExecutionContext*, QString const&, bool) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#6 0x00007fd4aa49fb68 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#7 0x00007fd4aa49ff79 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#8 0x00007fd4aa49d9cb in QV4::BuiltinFunction::call(QV4::Managed*, QV4::CallData*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#9 0x00007fd4aa500833 in QV4::Runtime::callProperty(QV4::ExecutionEngine*, int, QV4::CallData*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#10 0x00007fd4ab179be3 in ?? ()
#11 0x0000000002069810 in ?? ()
#12 0x00007fd4aa4803db in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#13 0x00007fd4aa4a0f1a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#14 0x00007fd4aa500833 in QV4::Runtime::callProperty(QV4::ExecutionEngine*, int, QV4::CallData*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#15 0x00007fd4ab179314 in ?? ()
#16 0x00007fff12ed6ea3 in ?? ()
#17 0x000000000206af10 in ?? ()
#18 0x00007fff12ed6ea4 in ?? ()
#19 0x0001800000000000 in ?? ()
#20 0x000000000000005a in ?? ()
#21 0x00007fd496e80648 in ?? ()
#22 0x00007fd496e806a0 in ?? ()
#23 0x00007fd496e806b0 in ?? ()
#24 0x00000000021059b0 in ?? ()
#25 0x00007fd4aa4a036a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#26 0x00007fd4aa5010c1 in QV4::Runtime::constructProperty(QV4::ExecutionEngine*, int, QV4::CallData*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#27 0x00007fd4949ccc5a in ?? ()
#28 0x00007fd496e80590 in ?? ()
#29 0x00007fd496e805e8 in ?? ()
#30 0x0003000000000001 in ?? ()
#31 0x00007fd496e80590 in ?? ()
#32 0x0000000000000000 in ?? ()

I am investigating ...

> I’m getting 15 failures when running the webapp_container test suite on my
> desktop. Those are regressions, all tests pass with trunk.

ok I managed to repro the crashes, I was using an stable version of oxide, with 1.13.6 I get the crash,

The crash goes away as soon as I remove the onMediaAccessPermissionRequested slot,

the stack trace is not very clean yet,

#0  0x00007fd4aa49cfd4 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#1  0x00007fd4aa47d1c9 in QV4::MemoryManager::mark() () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#2  0x00007fd4aa47dc0b in QV4::MemoryManager::runGC() () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#3  0x00007fd4aa47ed98 in QV4::MemoryManager::allocData(unsigned long, unsigned long) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#4  0x00007fd4aa464c6a in QV4::ExecutionEngine::newString(QString const&) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#5  0x00007fd4aa49e094 in QV4::Heap::FunctionObject::FunctionObject(QV4::ExecutionContext*, QString const&, bool) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#6  0x00007fd4aa49fb68 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#7  0x00007fd4aa49ff79 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#8  0x00007fd4aa49d9cb in QV4::BuiltinFunction::call(QV4::Managed*, QV4::CallData*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#9  0x00007fd4aa500833 in QV4::Runtime::callProperty(QV4::ExecutionEngine*, int, QV4::CallData*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#10 0x00007fd4ab179be3 in ?? ()
#11 0x0000000002069810 in ?? ()
#12 0x00007fd4aa4803db in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#13 0x00007fd4aa4a0f1a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#14 0x00007fd4aa500833 in QV4::Runtime::callProperty(QV4::ExecutionEngine*, int, QV4::CallData*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#15 0x00007fd4ab179314 in ?? ()
#16 0x00007fff12ed6ea3 in ?? ()
#17 0x000000000206af10 in ?? ()
#18 0x00007fff12ed6ea4 in ?? ()
#19 0x0001800000000000 in ?? ()
#20 0x000000000000005a in ?? ()
#21 0x00007fd496e80648 in ?? ()
#22 0x00007fd496e806a0 in ?? ()
#23 0x00007fd496e806b0 in ?? ()
#24 0x00000000021059b0 in ?? ()
#25 0x00007fd4aa4a036a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#26 0x00007fd4aa5010c1 in QV4::Runtime::constructProperty(QV4::ExecutionEngine*, int, QV4::CallData*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#27 0x00007fd4949ccc5a in ?? ()
#28 0x00007fd496e80590 in ?? ()
#29 0x00007fd496e805e8 in ?? ()
#30 0x0003000000000001 in ?? ()
#31 0x00007fd496e80590 in ?? ()
#32 0x0000000000000000 in ?? ()

I am investigating ...

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2016-03-16:

I updated the branch to fix the work around the crasher. As of now, it has been diagnosed as being oxide related, when a webview overrides a given context and the messageHandlers list, I will find a minimum example to repro the issue and file an oxide bug

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-03-16: