webbrowser-app

Merge lp://qastaging/~abreu-alexandre/webbrowser-app/saml-redirection-patterns into lp://qastaging/webbrowser-app

saml-redirection-patterns
Merge into trunk

Proposed by Alexandre Abreu on 2016-04-21

Status:

Merged

Approved by:

Alberto Mardegan on 2016-04-25

Approved revision:

1428

Merged at revision:

1429

Proposed branch:

lp://qastaging/~abreu-alexandre/webbrowser-app/saml-redirection-patterns

Merge into:

lp://qastaging/webbrowser-app

Diff against target:

96 lines (+32/-15)

2 files modified

src/app/webcontainer/WebViewImplOxide.qml (+23/-12)
tests/autopilot/webapp_container/tests/test_saml_url_patterns.py (+9/-3)

To merge this branch:

bzr merge lp://qastaging/~abreu-alexandre/webbrowser-app/saml-redirection-patterns

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Alberto Mardegan (community)			Approve on 2016-04-25
David Barth (community)		2016-04-21	Needs Fixing on 2016-04-22
PS Jenkins bot	continuous-integration		Needs Fixing on 2016-04-21
Review via email: mp+292561@code.qastaging.launchpad.net

Commit message

Track SAML requests that are part of redirection chains and do not trigger a navigation requested delegate.

Description of the change

Track SAML requests that are part of redirection chains and do not trigger a navigation requested delegate.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-04-21:

FAILED: Continuous integration, rev:1428
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2703/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6863/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1456/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1456/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1456/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6874/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2703/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

David Barth (dbarth) wrote on 2016-04-22:

Note: there seems to be a typo in WebViewImplOxide.qml which references an unknown popupWindowController, instead of popupController

Even with this change, the view in the overlay does not display. I see the overlay title changing as some content gets loaded and rendered, but the view is blank. Tested with Oxide 1.14.6.

review: Needs Fixing

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2016-04-22:

> Note: there seems to be a typo in WebViewImplOxide.qml which references an
> unknown popupWindowController, instead of popupController

this is handled by https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1572673

> Even with this change, the view in the overlay does not display. I see the
> overlay title changing as some content gets loaded and rendered, but the view
> is blank. Tested with Oxide 1.14.6.

it is a separate issue:

https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1573663