Merge lp://qastaging/~abreu-alexandre/webbrowser-app/theme-color-change-address-bar-widgets into lp://qastaging/webbrowser-app

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 1467
Merged at revision: 1490
Proposed branch: lp://qastaging/~abreu-alexandre/webbrowser-app/theme-color-change-address-bar-widgets
Merge into: lp://qastaging/webbrowser-app
Diff against target: 241 lines (+134/-29)
5 files modified
src/app/webcontainer/Chrome.qml (+11/-1)
src/app/webcontainer/WebApp.qml (+2/-1)
tests/autopilot/webapp_container/tests/__init__.py (+3/-2)
tests/autopilot/webapp_container/tests/fake_servers.py (+45/-0)
tests/autopilot/webapp_container/tests/test_page_meta_collector.py (+73/-25)
To merge this branch: bzr merge lp://qastaging/~abreu-alexandre/webbrowser-app/theme-color-change-address-bar-widgets
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+295859@code.qastaging.launchpad.net

Commit message

Handle theme color change and properly update browsing widgets

Description of the change

Handle theme color change and properly update browsing widgets

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

I would use property bindings on a new "elementsColor" property, but this is fine too.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: