Merge lp://qastaging/~achiang/network-manager-applet/precise-lp780602 into lp://qastaging/~network-manager/network-manager-applet/ubuntu.precise
Proposed by
Alex Chiang
| Status: | Merged |
|---|---|
| Approved by: | Mathieu Trudel-Lapierre |
| Approved revision: | 340 |
| Merged at revision: | 337 |
| Proposed branch: | lp://qastaging/~achiang/network-manager-applet/precise-lp780602 |
| Merge into: | lp://qastaging/~network-manager/network-manager-applet/ubuntu.precise |
| Diff against target: |
1668 lines (+606/-160) 5 files modified
debian/changelog (+13/-0) debian/patches/git_fix_some_leaks_80ef61b.patch (+336/-0) debian/patches/git_mac_addr_string_leakage_6dae878.patch (+94/-0) debian/patches/nm-applet-use-indicator.patch (+161/-160) debian/patches/series (+2/-0) |
| To merge this branch: | bzr merge lp://qastaging/~achiang/network-manager-applet/precise-lp780602 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | Approve | ||
|
Review via email:
|
|||
Description of the change
Backport several memory leaks from trunk that were fixed in 12.10 in the hopes that they fix LP: #780602
Packages built fine, and installed fine on my 12.04 amd64 laptop.
Currently doing a valgrind run to verify that things are better, but since these patches have been shipped for a long time, I think these are pretty safe.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looking good, with the only exception (at first glance) that the version should be 2.1 instead of 3. I'll do a more thorough review tomorrow ;)