Merge lp://qastaging/~ack/landscape-charm/enable-package-search into lp://qastaging/~landscape/landscape-charm/trunk

Proposed by Alberto Donato
Status: Merged
Approved by: Alberto Donato
Approved revision: 371
Merged at revision: 372
Proposed branch: lp://qastaging/~ack/landscape-charm/enable-package-search
Merge into: lp://qastaging/~landscape/landscape-charm/trunk
Diff against target: 25 lines (+2/-2)
2 files modified
lib/tests/test_templates.py (+1/-1)
templates/service.conf (+1/-1)
To merge this branch: bzr merge lp://qastaging/~ack/landscape-charm/enable-package-search
Reviewer Review Type Date Requested Status
Björn Tillenius (community) Approve
Данило Шеган (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+309534@code.qastaging.launchpad.net

Commit message

Enable package search by default.
This sets the account-threshold to zero, so that package search is used in all cases.

Description of the change

Enable package search by default.
This sets the account-threshold to zero, so that package search is used in all cases.

Testing instructions:

- run "make test" to verify the unittest change
- deploy an LDS and check that the setting is applied

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 371
Branch: lp:~ack/landscape-charm/enable-package-search
Jenkins: https://ci.lscape.net/job/latch-test-trusty/17/

review: Approve (test results)
Revision history for this message
Данило Шеган (danilo) wrote :

I might get to reviewing this later, but in case I don't (heading out to lunch), I want to make a note that this will mean that production will get it as well as soon as we switch to juju-deployed-hosted (not coming soon, though, so not an immediate concern, but if we want it to be custom-configurable, it'll involve changing the landscape-hosted-charm too).

Revision history for this message
Данило Шеган (danilo) :
review: Approve
Revision history for this message
Björn Tillenius (bjornt) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches