Merge lp://qastaging/~ack/landscape-client/migrate-test-scriptexecution into lp://qastaging/~landscape/landscape-client/trunk

Proposed by Alberto Donato
Status: Merged
Approved by: Alberto Donato
Approved revision: 852
Merged at revision: 874
Proposed branch: lp://qastaging/~ack/landscape-client/migrate-test-scriptexecution
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 297 lines (+104/-63)
1 file modified
landscape/manager/tests/test_scriptexecution.py (+104/-63)
To merge this branch: bzr merge lp://qastaging/~ack/landscape-client/migrate-test-scriptexecution
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Free Ekanayaka (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+297558@code.qastaging.launchpad.net

Commit message

Replace mocker use in some of the test_scriptexecution tests.

Description of the change

Replace mocker use in some of the test_scriptexecution tests.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 851
Branch: lp:~ack/landscape-client/migrate-test-scriptexecution
Jenkins: https://ci.lscape.net/job/latch-test/5062/

review: Approve (test results)
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

+1 with a few nits

review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

+1

review: Approve
852. By Alberto Donato

Address review comments.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: