Web addons for OpenERP

Reviewer	Review Type	Date Requested	Status
Pedro Manuel Baeza	code review and test	2014-04-18	Approve on 2014-05-19
Sylvain LE GAL (GRAP) (community)	code review, test	2014-04-18	Approve on 2014-05-14
arthru (community)	tested		Approve on 2014-04-22
Review via email: mp+216422@code.qastaging.launchpad.net

Description of the change

[FIX] web_easy_switch_company: propose the correct companies to non-admin users

Emulate the exact behaviour of the stock user preferences form.

lp://qastaging/~acsone-openerp/web-addons/bug-1303944-sbi updated on 2014-04-18

32. By Stéphane Bidoul (Acsone) on 2014-04-18: Added a comment about an issue with the logos

Revision history for this message

arthru (arthru) wrote on 2014-04-22:

Tested with admin and non admin users.

review: Approve (tested)

Revision history for this message

Stéphane Bidoul (Acsone) (sbi) wrote on 2014-04-22:

Note: logos do not display correctely, and, as far as I can tell, there is no way to make this work with the default record rule.

Revision history for this message

Sylvain LE GAL (GRAP) (sylvain-legal) wrote on 2014-05-14:

LGTM.

Sorry for the late.

+++

review: Approve (code review, test)

Revision history for this message

Stéphane Bidoul (Acsone) (sbi) wrote on 2014-05-14:

Hi Sylvain, thanks for the review.

What do you think about the logos. In practice they don't display properly with non admin users and I see no way out of that. Should we remove them?

-sbi

Revision history for this message

Sylvain LE GAL (GRAP) (sylvain-legal) wrote on 2014-05-14:

Hi Stéphane,

I don't have a precise idea about that.
I'm pretty in favor to keep that feature because :
- it works for admin user and doesn't bug with non-admin users;
- It works if admin user decide to change default ACL;

I'm agree : it's not very clean. (but OpenERP Core is not very clean in that case...)

Other point of you ?

Regards.

Revision history for this message

Stéphane Bidoul (Acsone) (sbi) wrote on 2014-05-14:

I'm fine with your view. It does not crash indeed and users don't complain. So let's keep it that way for now.

Thanks again for this neat module!

-sbi

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-05-19:

I have tried and it works good for admin and non admin users. It's a pity the logos issue, but module is very good even with that!

Regards