Charm Helpers

Merge lp://qastaging/~adam-collard/charm-helpers/fix-amulet-utils-validate-services-by-name into lp://qastaging/charm-helpers

  1. fix-amulet-utils-validate-services-by-name
  2. Merge into devel
Proposed by Adam Collard
Status: Merged
Merged at revision: 427
Proposed branch: lp://qastaging/~adam-collard/charm-helpers/fix-amulet-utils-validate-services-by-name
Merge into: lp://qastaging/charm-helpers
Diff against target: 190 lines (+125/-10)
3 files modified
charmhelpers/contrib/amulet/utils.py (+18/-10)
test_requirements.txt (+2/-0)
tests/contrib/amulet/test_utils.py (+105/-0)
To merge this branch: bzr merge lp://qastaging/~adam-collard/charm-helpers/fix-amulet-utils-validate-services-by-name
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Review via email: mp+267817@code.qastaging.launchpad.net

Description of the change

Make the validate_services_by_name check actually verify that Upstart jobs are running and not just "existing".

Drive-by fixes for Python3 compatibility and dependencies for running tests (i.e. amulet, distro-info)

To post a comment you must log in.
lp://qastaging/~adam-collard/charm-helpers/fix-amulet-utils-validate-services-by-name updated
428. By Adam Collard

Add test files

Revision history for this message
Chris Glass (tribaal) wrote :

+1, thanks for your fix.

(Unit and amulet tests pass)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches