lp://qastaging/~adam-collard/landscape-client/drop-mocker

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/~landscape/landscape-client/trunk at revision 912

Björn Tillenius (community): Approve on 2016-06-17

Alberto Donato (community): Approve on 2016-06-17

🤖 Landscape Builder: Approve (test results) on 2016-06-17

Diff: 2287 lines (+51/-2164)

3 files modified

Makefile (+1/-1)
landscape/tests/helpers.py (+50/-8)
landscape/tests/mocker.py (+0/-2155)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1592875: remove mocker

Medium

Fix Committed

Link a bug report

Related blueprints

912. By Adam Collard on 2016-06-17

Actually remove copy of mocker

911. By Chad Smith on 2016-06-16

[tivial mocker retirement] [a=sparkiegeek, bbsw]

910. By Данило Шеган on 2016-06-16

Merge mock-tests-watchdog-middle [f=1592875] [r=landscape-builder,tealeg,adam-collard] [a=Данило Шеган]
Make a twisted mockery of landscape.tests.test_watchdog.DaemonTest.

909. By Alberto Donato on 2016-06-16

Remove Mocker references from comments. [trivial] [r=blackboxsw,simpoir]

908. By Adam Collard on 2016-06-16

Merge mocker-replace-reporter-run [f=1592875] [r=landscape-builder,chad.smith,tealeg] [a=Adam Collard]
Mock out fetch_async in test_reporter.py and sort out the test_run method.

907. By Chad Smith on 2016-06-16

Merge mocker-to-mock-package-reporter-2 [f=1592875] [r=ack,tribaal,tealeg,landscape-builder] [a=Chad Smith]
Time to retire mocker, you have lived a good life.
Phase 2 test_reporter mocker-> mock

906. By Adam Collard on 2016-06-16

Merge mocker-replace-watchdog-service-tests [f=1592875] [r=adam-collard,bogdana,ack,landscape-builder] [a=Adam Collard]
Move WatchDogServiceTest from mocker to mock.

905. By Geoff Teale on 2016-06-16

Merge mocker-replace-test-changer [f=1592875] [r=simpoir,ack] [a=Geoff Teale]
Replace mocker with mock and patch.

Note that tests that were previously writing shell script and executing those scripts have been *radically* simplified - at least one of these was previous failing to execute it's deferred assertions.

Testing instructions:

904. By Chris Glass on 2016-06-16

Fix docstring [trivial] [r=bogdana]

903. By Chris Glass on 2016-06-16

Fixed tests on Xenial [trivial] [r=tealeg]