Landscape Client

Merge lp://qastaging/~adam-collard/landscape-client/mocker-replace-configuration-part-deux into lp://qastaging/~landscape/landscape-client/trunk

  1. mocker-replace-configuration-part-deux
  2. Merge into trunk
Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 852
Merged at revision: 889
Proposed branch: lp://qastaging/~adam-collard/landscape-client/mocker-replace-configuration-part-deux
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 1387 lines (+397/-489)
1 file modified
landscape/tests/test_configuration.py (+397/-489)
To merge this branch: bzr merge lp://qastaging/~adam-collard/landscape-client/mocker-replace-configuration-part-deux
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Review via email: mp+297629@code.qastaging.launchpad.net

Commit message

Convert ConfigurationFunctionsTest to replace use of mocker with mock

Follow on branches will cover the remaining use of mocker in the tests.

Description of the change

Convert ConfigurationFunctionsTest to replace use of mocker with mock

Follow on branches will cover the remaining use of mocker in the tests.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 850
Branch: lp:~adam-collard/landscape-client/mocker-replace-configuration-part-deux
Jenkins: https://ci.lscape.net/job/latch-test/5087/

review: Approve (test results)
Revision history for this message
Данило Шеган (danilo) wrote :

For the lint I mentioned, I am still seeing the following:

=== pyflakes ===

landscape/tests/test_configuration.py:14: 'stop_client_and_disable_init_script' imported but unused
landscape/tests/test_configuration.py:24: 'SysVConfig' imported but unused
landscape/tests/test_configuration.py:27: 'CONTAINS' imported but unused
landscape/tests/test_configuration.py:27: 'ANY' imported but unused

(on xenial)

Revision history for this message
Chris Glass (tribaal) wrote :

+1

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 851
Branch: lp:~adam-collard/landscape-client/mocker-replace-configuration-part-deux
Jenkins: https://ci.lscape.net/job/latch-test/5090/

review: Approve (test results)
lp://qastaging/~adam-collard/landscape-client/mocker-replace-configuration-part-deux updated
852. By Adam Collard

Fix typo (thanks danilo!)

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 852
Branch: lp:~adam-collard/landscape-client/mocker-replace-configuration-part-deux
Jenkins: https://ci.lscape.net/job/latch-test/5094/

review: Approve (test results)
Revision history for this message
Данило Шеган (danilo) wrote :

Here's a reluctant +1 for you, Adam.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: