Merge lp://qastaging/~adam-collard/landscape-client/mocker-replace-reporter-run into lp://qastaging/~landscape/landscape-client/trunk
Proposed by
Adam Collard
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Adam Collard | ||||
| Approved revision: | 911 | ||||
| Merged at revision: | 908 | ||||
| Proposed branch: | lp://qastaging/~adam-collard/landscape-client/mocker-replace-reporter-run | ||||
| Merge into: | lp://qastaging/~landscape/landscape-client/trunk | ||||
| Prerequisite: | lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter-2 | ||||
| Diff against target: |
300 lines (+50/-81) 1 file modified
landscape/package/tests/test_reporter.py (+50/-81) |
||||
| To merge this branch: | bzr merge lp://qastaging/~adam-collard/landscape-client/mocker-replace-reporter-run | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| 🤖 Landscape Builder | test results | Approve | |
| Chad Smith | Approve | ||
| Geoff Teale (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Mock out fetch_async in test_reporter.py and sort out the test_run method.
Description of the change
Mock out fetch_async in test_reporter.py and sort out the test_run method.
To post a comment you must log in.
Revision history for this message
| Chad Smith (chad.smith) | # |
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) | # |
review:
Abstain
(executing tests)
Revision history for this message
| Adam Collard (adam-collard) | # |
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 Bloomin' lovely