Merge lp://qastaging/~adam-collard/landscape-client/mocker-replace-watchdog-run-tests into lp://qastaging/~landscape/landscape-client/trunk

Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 891
Merged at revision: 900
Proposed branch: lp://qastaging/~adam-collard/landscape-client/mocker-replace-watchdog-run-tests
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 98 lines (+23/-25)
1 file modified
landscape/tests/test_watchdog.py (+23/-25)
To merge this branch: bzr merge lp://qastaging/~adam-collard/landscape-client/mocker-replace-watchdog-run-tests
Reviewer Review Type Date Requested Status
Free Ekanayaka (community) Approve
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Review via email: mp+297658@code.qastaging.launchpad.net

Commit message

Port WatchDogRunTests to mock in favour of mocker.

Note that this branch re-uses the fakepwd that Twisted ships.

Description of the change

Port WatchDogRunTests to mock in favour of mocker.

Note that this branch re-uses the fakepwd that Twisted ships.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Chris Glass (tribaal) wrote :

+1!

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 890
Branch: lp:~adam-collard/landscape-client/mocker-replace-watchdog-run-tests
Jenkins: https://ci.lscape.net/job/latch-test/5104/

review: Approve (test results)
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

+1

review: Approve
891. By Adam Collard

Make fake_pwd public (free's review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: