Merge lp://qastaging/~adam-collard/tarmac/milestone-filter-by-series into lp://qastaging/tarmac
Proposed by
Adam Collard
Status: | Rejected |
---|---|
Rejected by: | Adam Collard |
Proposed branch: | lp://qastaging/~adam-collard/tarmac/milestone-filter-by-series |
Merge into: | lp://qastaging/tarmac |
Diff against target: |
208 lines (+36/-33) 2 files modified
tarmac/plugins/bugresolver.py (+13/-12) tarmac/plugins/tests/test_bugresolver.py (+23/-21) |
To merge this branch: | bzr merge lp://qastaging/~adam-collard/tarmac/milestone-filter-by-series |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey | Needs Fixing | ||
Chris Glass (community) | Approve | ||
Данило Шеган (community) | Approve | ||
Review via email: mp+278946@code.qastaging.launchpad.net |
Description of the change
When setting the milestone, only look for milestones which match the series that the bug has been committed on.
To post a comment you must log in.
Unmerged revisions
- 435. By Adam Collard
-
No need to walk next_collection links
- 434. By Adam Collard
-
fix lint
- 433. By Adam Collard
-
Filter by series
LGTM (tests, lint all pass as well). FWIW, the default collections batch size LP seems to use is 75 items, so this is needed when you've got more milestones than that.