Merge lp://qastaging/~adam.russell/pyexiv2/pyexiv2-0.3 into lp://qastaging/pyexiv2
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~adam.russell/pyexiv2/pyexiv2-0.3 |
| Merge into: | lp://qastaging/pyexiv2 |
| Diff against target: |
57 lines (+40/-0) 3 files modified
.bzrignore (+2/-0) setup.py (+25/-0) src/libexiv2python.py (+13/-0) |
| To merge this branch: | bzr merge lp://qastaging/~adam.russell/pyexiv2/pyexiv2-0.3 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Olivier Tilloy | Pending | ||
|
Review via email:
|
|||
Description of the change
I have added a setup.py file for you. I didn't want to touch the system you have in place with scons, though, so I worked around that. However, I (and many others, I'm sure) love the pip and virtualenv tools, and currently pyexiv2 isn't very friendly with those. This branch allows pyexiv2 to easily be installed by pip, e.g.:
pip install -e bzr+lp:~adam.russell/pyexiv2/pyexiv2-0.3#egg=pyexiv2
This branch will make things easier on any project that depends on pyexiv2, as they will be able to put it in a requirements.txt file. It's a step closer to being able to put pyexiv2 on PyPI, too, if that's something you want to do.
I should note that I only tested these changes with Python 2.7. Not sure how old of a Python version you want to support, or if that even really matters. Anyway, let me know if you have any questions about what I wrote or if there are any changes you'd like me to make.
| Olivier Tilloy (osomon) wrote | # |
| Hobson Lane (hobs) wrote | # |
| Adam (adam.russell) wrote | # |
| Olivier Tilloy (osomon) wrote | # |
Thanks for your contribution Adam!
I’m not familiar with pip and virtualenv myself, but I guess making pyexiv2 more accessible to developers who use those tools can only be a good thing.
I don’t have much spare time on my hands now, but I’ll eventually review your code, thanks in advance for your patience.
I hadn’t though of publishing pyexiv2 on PyPI before (it’s already available in a number of distributions as native packages), but it can’t hurt :)
Regarding the versions of Python supported, it’s 2.6 and upwards (unfortunately Python 3 is not supported yet). When I get to testing your code I’ll make sure I test with 2.6 too.