Merge lp://qastaging/~afrantzis/jenkins-launchpad-plugin/triggered-builds into lp://qastaging/jenkins-launchpad-plugin

Proposed by Alexandros Frantzis
Status: Merged
Approved by: Michał Sawicz
Approved revision: 133
Merged at revision: 129
Proposed branch: lp://qastaging/~afrantzis/jenkins-launchpad-plugin/triggered-builds
Merge into: lp://qastaging/jenkins-launchpad-plugin
Diff against target: 244 lines (+130/-3)
3 files modified
jlp/jenkinsutils.py (+57/-1)
tests/__init__.py (+56/-1)
tests/test_jenkinsutils.py (+17/-1)
To merge this branch: bzr merge lp://qastaging/~afrantzis/jenkins-launchpad-plugin/triggered-builds
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+284117@code.qastaging.launchpad.net

Commit message

Include triggered builds in reported downstream builds when creating MP vote message.

This is required because new versions of the triggered build plugin don't report triggered builds as downstream.

Description of the change

Include triggered builds in reported downstream builds when creating MP vote message.

This is required because new versions of the triggered build plugin don't report triggered builds as downstream.

To test locally run the following script from within the project directory:

import jlp.jenkinsutils
import sys

print(jlp.jenkinsutils.get_executed_test_runs_message(sys.argv[1]))

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
130. By Alexandros Frantzis

Fix PEP8 complaints

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
131. By Alexandros Frantzis

More PEP8 fixes for trusty

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
132. By Alexandros Frantzis

Fix variable initialization

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) :
review: Needs Fixing
133. By Alexandros Frantzis

Added comment for upstream project check

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Replying to self: set() could break ordering, so using lists is better here.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches