Mir

Merge lp://qastaging/~afrantzis/mir/android-one-buffer-allocator into lp://qastaging/mir

  1. android-one-buffer-allocator
  2. Merge into development-branch
Proposed by Alexandros Frantzis
Status: Merged
Merged at revision: 3123
Proposed branch: lp://qastaging/~afrantzis/mir/android-one-buffer-allocator
Merge into: lp://qastaging/mir
Diff against target: 213 lines (+41/-48)
3 files modified
src/platforms/android/server/platform.cpp (+30/-41)
src/platforms/android/server/platform.h (+2/-3)
tests/unit-tests/graphics/android/test_platform.cpp (+9/-4)
To merge this branch: bzr merge lp://qastaging/~afrantzis/mir/android-one-buffer-allocator
Reviewer Review Type Date Requested Status
Andreas Pokorny (community) Approve
Kevin DuBois (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+278441@code.qastaging.launchpad.net

Commit message

android: Create and use a single buffer allocator instance

Description of the change

android: Create and use a single buffer allocator instance

This change fixed (worked around?) the segmentation faults I was seeing locally on krillin, and which match the ones we are seeing in CI. I am not sure how/why this improves the situation, since the problem seems to come from gralloc and we can't investigate further (no sources). Let's see what CI thinks.

To post a comment you must log in.
Revision history for this message
Kevin DuBois (kdub) wrote :

It is a workaround, but not that bad of one. If it does work, lets put an obvious comment in there about why we should only have one gralloc instance.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3123
http://jenkins.qa.ubuntu.com/job/mir-ci/5651/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5012
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3918
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4958/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/914/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1804
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1804/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/912
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/912/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4958
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4958/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7504/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25457
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/915/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5651/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Didn't work for CI :/

Revision history for this message
Kevin DuBois (kdub) wrote :

Even if it didn't work for CI, it does work around the driver bug better than what we have currently, and should land

review: Approve
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

yes makes sense, since reduces it to only a single allocator..

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches